Split GA4 event product_download into product specific events Fix #14072 #14083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephaniehobson
force-pushed
the
ga4_download
branch
11 times, most recently
from
9911c21 to
b68981d
Compare
stephaniehobson
changed the title
stephaniehobson
force-pushed
the
ga4_download
branch
from
b68981d to
f6bca0b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14083 +/- ##
=======================================
Coverage 77.07% 77.07%
=======================================
Files 145 145
Lines 7886 7886
=======================================
Hits 6078 6078
Misses 1808 1808 ☔ View full report in Codecov by Sentry. |
stephaniehobson
force-pushed
the
ga4_download
branch
from
f6bca0b to
2bcd1b4
Compare
stephaniehobson
added
Needs Review
alexgibson
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Split GA4 event
product_downloadinto product specific conversion events and keepproduct_downloadaround for a few months to help compare before/after changes.Significant changes and points to review
[product name]_downloadandproduct_download.Issue / Bugzilla link
Fix #14072
A task to remove the old
product_downloadevent has been added to #13238 (I'll flesh it out as a real issue once I have an idea of the timeline to remove it.)Testing
firefox_download: http://localhost:8000/en-US/firefox/all/firefox_mobile_download: http://localhost:8000/en-US/firefox/browsers/mobile/android/focus_download: http://localhost:8000/en-US/firefox/browsers/mobile/focus/klar_download: http://localhost:8000/de/firefox/browsers/mobile/focus/pocket_download: http://localhost:8000/en-US/firefox/event.preventDefault()I was using for debugging